rymurr commented on a change in pull request #2399:
URL: https://github.com/apache/iceberg/pull/2399#discussion_r607780596
##########
File path: python/iceberg/api/expressions/literals.py
##########
@@ -76,6 +77,7 @@ class Literal(object):
JAVA_MIN_INT = -2147483648
JAVA_MAX_FLOAT = 3.4028235E38
JAVA_MIN_FLOAT = -3.4028235E38
+ value: Any
Review comment:
Not sure I love the class variable here. And its not being used below
(the `self.value` in `BaseLiteral` hides it). Maybe thsi should be an `abc.ABC`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
