rymurr commented on a change in pull request #2399:
URL: https://github.com/apache/iceberg/pull/2399#discussion_r608045892



##########
File path: python/iceberg/api/expressions/literals.py
##########
@@ -76,6 +77,7 @@ class Literal(object):
     JAVA_MIN_INT = -2147483648
     JAVA_MAX_FLOAT = 3.4028235E38
     JAVA_MIN_FLOAT = -3.4028235E38
+    value: Any

Review comment:
       thats cool. I think we can also just remove the `value: Any` since its 
not used anywhere else in the class. The static method doesn't use it right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to