TGooch44 commented on a change in pull request #2399:
URL: https://github.com/apache/iceberg/pull/2399#discussion_r607989089
##########
File path: python/iceberg/api/expressions/literals.py
##########
@@ -76,6 +77,7 @@ class Literal(object):
JAVA_MIN_INT = -2147483648
JAVA_MAX_FLOAT = 3.4028235E38
JAVA_MIN_FLOAT = -3.4028235E38
+ value: Any
Review comment:
I believe the `value` is there purely to satisfy mypy checks(per [this
PEP](https://www.python.org/dev/peps/pep-0526/ ) . I do think you are correct
that the Literal Class is kinda useless, I'll need to double check, but I think
I could just make everything BaseLiteral, which does already have `value` as a
instance variable, and move the constants and the `of` method out to be in the
file global scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
