flyrain commented on pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#issuecomment-821526734


   > > schema, partitionSpec, and partition Id part of table as well
   > 
   > We used to derive this information from the table object and pass 
individual things as the table wasn't serializable. Each time we needed one 
more entity, we had to modify a lot of places. Hopefully, this won't be needed 
after this change.
   
   I meant this place, but it makes sense since rewrite may need a different 
partitionSec, sorry for the confusing.
   ```
   public OutputFileFactory(Table table, PartitionSpec spec, FileFormat format, 
int partitionId, long taskId) {
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to