[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2362: Spark: Pass Table object to executors

[GitBox]

aokolnychyi commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r616339228



##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -520,10 +500,9 @@ private InternalRowReaderFactory() {
     }
 
     @Override
-    public InputPartitionReader<InternalRow> create(CombinedScanTask task, 
Schema tableSchema, Schema expectedSchema,
-                                                    String nameMapping, FileIO 
io,
-                                                    EncryptionManager 
encryptionManager, boolean caseSensitive) {
-      return new RowReader(task, tableSchema, expectedSchema, nameMapping, io, 
encryptionManager, caseSensitive);
+    public InputPartitionReader<InternalRow> create(CombinedScanTask task, 
Table table,

Review comment:
       I am paranoid about such things :) It feels a bit unbalanced with only 
caseSensitive on a new line.
   
   <img width="867" alt="image" 
src="https://user-images.githubusercontent.com/6235869/115338554-e4ee9600-a157-11eb-8815-38e00842c83c.png";>
   
   <img width="772" alt="image" 
src="https://user-images.githubusercontent.com/6235869/115338596-fafc5680-a157-11eb-94b5-c78180a4d6ad.png";>
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org