RussellSpitzer commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r616221285
##########
File path:
spark/src/main/java/org/apache/iceberg/actions/RewriteDataFilesAction.java
##########
@@ -59,10 +59,8 @@ protected FileIO fileIO() {
@Override
protected List<DataFile> rewriteDataForTasks(List<CombinedScanTask>
combinedScanTasks) {
JavaRDD<CombinedScanTask> taskRDD =
sparkContext.parallelize(combinedScanTasks, combinedScanTasks.size());
- Broadcast<FileIO> io = sparkContext.broadcast(fileIO());
- Broadcast<EncryptionManager> encryption =
sparkContext.broadcast(encryptionManager());
- RowDataRewriter rowDataRewriter =
- new RowDataRewriter(table(), spec(), caseSensitive(), io, encryption);
+ Broadcast<Table> tableBroadcast =
sparkContext.broadcast(SerializableTable.copyOf(table()));
+ RowDataRewriter rowDataRewriter = new RowDataRewriter(tableBroadcast,
spec(), caseSensitive());
Review comment:
Why pass through spec()? Can this be customized by this class? Shouldn't
it be forced to be the table.spec()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
