RussellSpitzer commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r616224919
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -520,10 +500,9 @@ private InternalRowReaderFactory() {
}
@Override
- public InputPartitionReader<InternalRow> create(CombinedScanTask task,
Schema tableSchema, Schema expectedSchema,
- String nameMapping, FileIO
io,
- EncryptionManager
encryptionManager, boolean caseSensitive) {
- return new RowReader(task, tableSchema, expectedSchema, nameMapping, io,
encryptionManager, caseSensitive);
+ public InputPartitionReader<InternalRow> create(CombinedScanTask task,
Table table,
Review comment:
Spacing on this and the method below seems odd ... I think
expectedSchema would fit on the previous line? I don't really mind though but
usually this sort of thing bugs you :) Fine as is if you don't want to just
have a single dangling caseSensitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
