kbendick commented on a change in pull request #2816:
URL: https://github.com/apache/iceberg/pull/2816#discussion_r670161636
##########
File path: gradlew
##########
@@ -64,10 +64,6 @@ case "`uname`" in
;;
esac
-if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
- curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar
https://raw.githubusercontent.com/gradle/gradle/v5.4.1/gradle/wrapper/gradle-wrapper.jar
-fi
-
Review comment:
Is this no longer needed at all? Did the usage of the gradle-wrapper.jar
for gradle 5.6.4? I’m surprised that this line is no longer needed given that
this jar is still referenced on the old line 71 / new line 67
(https://github.com/apache/iceberg/pull/2816/files#diff-e9721dc750619a21053ddea8a5d04929a608877d8c5daec1b57d243d3424e745R67)
Have you tested that this works on fresh system without the gradle wrapper
jar present?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
