kbendick commented on a change in pull request #2816:
URL: https://github.com/apache/iceberg/pull/2816#discussion_r670166317
##########
File path: gradlew
##########
@@ -28,7 +28,7 @@ APP_NAME="Gradle"
APP_BASE_NAME=`basename "$0"`
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to
pass JVM options to this script.
-DEFAULT_JVM_OPTS=""
+DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
Review comment:
If you’re optimizing for build cache (and for gradle runtimes in
general), I would think raising this might be beneficial. Particularly, for
compiling scala code I usually see it recommended that the gradle JVM get more
memory.
I would personally suggest `-Xmx1024m -XX:MaxPermSize=256m`, but I also see
many articles recommending at least `DEFAULT_JVM_OPTS="-Xmx512m"`.
Your call I guess, but I’d consider being sure that the values you’re using
there as the default are still being used currently despite being explicitly
zero’d out currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
