runningcode commented on a change in pull request #2816:
URL: https://github.com/apache/iceberg/pull/2816#discussion_r670346771
##########
File path: gradlew
##########
@@ -64,10 +64,6 @@ case "`uname`" in
;;
esac
-if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
- curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar
https://raw.githubusercontent.com/gradle/gradle/v5.4.1/gradle/wrapper/gradle-wrapper.jar
-fi
-
Review comment:
The standard setup for a Gradle build is to include the Gradle wrapper
jar in the project. I just noticed that this is not the case for Apache
Iceberg. Can we check in the wrapper to make it a more standard setup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
