runningcode commented on a change in pull request #2816:
URL: https://github.com/apache/iceberg/pull/2816#discussion_r670348281



##########
File path: gradlew
##########
@@ -28,7 +28,7 @@ APP_NAME="Gradle"
 APP_BASE_NAME=`basename "$0"`
 
 # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to 
pass JVM options to this script.
-DEFAULT_JVM_OPTS=""
+DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'

Review comment:
       This is not the heap size used for the build and Gradle Daemon. My 
understanding is that these are the settings used for the Gradle client. See 
more info on configuring the heap size here: 
https://docs.gradle.org/current/userguide/build_environment.html#sec:configuring_jvm_memory
   
   The iceberg project has the heap size already configured in the 
`gradle.properties` here: 
https://github.com/apache/iceberg/blob/master/gradle.properties#L19
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to