kbendick commented on a change in pull request #2878:
URL: https://github.com/apache/iceberg/pull/2878#discussion_r685816190
##########
File path: api/src/main/java/org/apache/iceberg/io/FileIO.java
##########
@@ -66,4 +66,10 @@ default void deleteFile(OutputFile file) {
*/
default void initialize(Map<String, String> properties) {
}
+
+ /**
+ * Close File IO and release underlying resources.
+ */
+ default void close() {
Review comment:
Nit: Possibly add some documentation here about whether or not `close`
needs to be called? Currently it's somewhat confusing (as the underlying issue
is somewhat confusing), but end user's are exposed this API and encouraged /
allowed to write their own FileIO per the docs, so I feel that the requirements
should be clearly laid out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
