yyanyy commented on a change in pull request #2878:
URL: https://github.com/apache/iceberg/pull/2878#discussion_r694184807
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
##########
@@ -80,6 +81,7 @@
private AwsProperties awsProperties;
private FileIO fileIO;
private LockManager lockManager;
+ private CloseGroupHelper closeGroupHelper;
Review comment:
Just to ensure I understand the suggestion, do you mean to make this
class implement `CloseableGroup` or move the logic from `CloseGroupHelper` to
`CloseableGroup` and continue to declare a `private CloseableGroup
closeableGroup = new CloseableGroup(){}` here? If the former, Ryan M and I had
a discussion around this in
https://github.com/apache/iceberg/pull/2878#discussion_r678098958 but I should
be able to do the latter. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
