rymurr commented on a change in pull request #2878: URL: https://github.com/apache/iceberg/pull/2878#discussion_r685835452
########## File path: api/src/main/java/org/apache/iceberg/io/CloseGroupUtil.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class CloseGroupUtil { + private static final Logger LOG = LoggerFactory.getLogger(CloseGroupUtil.class); + + private CloseGroupUtil() { + } + + public static void closeAutoCloseables(boolean suppressCloseFailure, AutoCloseable... closeables) throws Exception { Review comment: A javadoc would be useful here to clarify the supression and its effect. ########## File path: api/src/main/java/org/apache/iceberg/io/FileIO.java ########## @@ -66,4 +66,10 @@ default void deleteFile(OutputFile file) { */ default void initialize(Map<String, String> properties) { } + + /** + * Close File IO and release underlying resources. + */ + default void close() { Review comment: I agree w. @kbendick. I don't think we should extend `AutoCloseable` *and* add a default impl. I think there is a good argument to have `FileIO` implement `Closeable` (rather than `Autocloseable` as its fairly explicitly related to IO), what do you think @rdblue? But I would make `FileIO` implementations implement `close` rather than add a default here, otherwise its not clear to implementers that they may have to deal w/ closing their resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
