yyanyy commented on a change in pull request #2878:
URL: https://github.com/apache/iceberg/pull/2878#discussion_r690758046
##########
File path: api/src/main/java/org/apache/iceberg/io/FileIO.java
##########
@@ -66,4 +66,10 @@ default void deleteFile(OutputFile file) {
*/
default void initialize(Map<String, String> properties) {
}
+
+ /**
+ * Close File IO and release underlying resources.
+ */
+ default void close() {
Review comment:
Thanks for the feedback! I will update the comment but for the default
impl, I mentioned this a little bit in the other response I had, the reason for
me to add a default implementation here was because I think this use case of
having to call `close` is rare and for the majority of the use case it is not
needed, and because of this, to me breaking compatibility of custom FileIO
implementation by adding a non-default method in the interface might not be
worth it. Please let me know if you have more feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
