rdblue commented on a change in pull request #2878:
URL: https://github.com/apache/iceberg/pull/2878#discussion_r694287044
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
##########
@@ -80,6 +81,7 @@
private AwsProperties awsProperties;
private FileIO fileIO;
private LockManager lockManager;
+ private CloseGroupHelper closeGroupHelper;
Review comment:
Yeah, I like the idea to use `CloseableGroup` and merge the helper
there. There is no reason for that class to be abstract -- that just prevents
it from being used for composition rather than inheritance. We can also use
`ExceptionUtil.castAndThrow` to fix up the exception handling in it and update
`addCloseable` to accept `AutoCloseable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
