kbendick commented on pull request #3116: URL: https://github.com/apache/iceberg/pull/3116#issuecomment-919421113
> 1. The options are not checked in `FlinkCatalogFactory.createCatalog()`, this is to be compatible with the old implementation. And this way we can use customized options as before without pre-settings. +1 to this. We have a number of customized options for things like AWS s3 / IAM etc that go on catalogs and we need to be able to support them. > 2. The implementation is not compatible with Flink 1.12 because CatalogFactory interface does not extend Factory interface in 1.12. Does this mean we're dropping support entirely for Flink 1.12 in the next release (and effectively in the master branch)? This seems potentially premature. I thought that the Flink 1.13 interface added `Factory`, but kept the old interface that was extended in 1.12 for backwards compatibility. Is it possible we can do the same @Flyangz? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
