Flyangz commented on pull request #3116: URL: https://github.com/apache/iceberg/pull/3116#issuecomment-921782417
How about this time? @kbendick It can support both 1.12 and 1.13, though it implements deprecated methods([`requiredContext`, `supportedProperties` and `supportedProperties` marked deprecated at 1.13](https://github.com/apache/flink/blob/release-1.13.2/flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogFactory.java)). @zhangjun0x01's original PR does not support 1.12, because that PR implements `Factory` interface API, like `factoryIdentifier` and `requiredOptions`. But [1.12's CatalogFactory does not extend `Factory`](https://github.com/apache/flink/blob/release-1.12.1/flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogFactory.java). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
