kbendick edited a comment on pull request #3116: URL: https://github.com/apache/iceberg/pull/3116#issuecomment-919725987
> we do not have the plan of improving flink to 1.13 recently, is there a way to support both 1.12 and 1.13 versions. I believe that @zhangjun0x01's original PR supported both flink 1.12 and flink 1.13. Like I mentioned, if the `FlinkCatalogFactory` implements both APIs, will that not suffice to support both 1.12 and 1.13? Dropping support for Flink 1.12 is a big decision in my opinion, and should be brought up on the mailing list or at the community sync-up. Does my idea of continuing to implement `TableFactory`, in addition to adding the newer `Factory` interface functions, just like [Flink's `CatalogFactory` does itself ](https://github.com/apache/flink/blob/f74db4b6cce9a28f484dc9d5e6470a50b15c121a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogFactory.java#L40) not work? I thought that was why Flink's `CatalogFactory` implemented both the old interface and the new interface, to mark the old interface as deprecated but still support both versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
