Flyangz commented on pull request #3116: URL: https://github.com/apache/iceberg/pull/3116#issuecomment-921912251
This committed code implements both `TableFactory` and `Factory`. [Actually, Flink 1.13 would continue to use `TableFactory` API](https://github.com/apache/flink/blob/5f007ff6c8224c6e5a14de2c79296eb85a22fe1f/flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java#L240). So only implementing `TableFactory` is the method with the least changes and the lowest risk to upgrade to 1.13. Which way do you prefer? Implementing both or just `TableFactory`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
