rdblue commented on a change in pull request #3099:
URL: https://github.com/apache/iceberg/pull/3099#discussion_r711826452
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -47,10 +49,15 @@ public HiveClientPool(int poolSize, Configuration conf) {
}
@Override
- protected HiveMetaStoreClient newClient() {
+ protected boolean shouldRetry() {
+ return false; // Already use RetryingMetaStoreClient
+ }
+
+ @Override
+ protected IMetaStoreClient newClient() {
try {
try {
- return CLIENT_CTOR.newInstance(hiveConf);
+ return CLIENT_CTOR.invoke(hiveConf, true);
Review comment:
Can you please add a comment that documents the `true` here? Something
like this:
```
return GET_CLIENT.invoke(hiveConf, true /* use retries */);
```
I'm assuming that the `true` is retry related? If so, should this detect
whether the Hive implementation will retry and turn retries back on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
