jackye1995 commented on a change in pull request #3099:
URL: https://github.com/apache/iceberg/pull/3099#discussion_r713647520
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -47,10 +49,15 @@ public HiveClientPool(int poolSize, Configuration conf) {
}
@Override
- protected HiveMetaStoreClient newClient() {
+ protected boolean shouldRetry() {
+ return false; // Already use RetryingMetaStoreClient
+ }
+
+ @Override
+ protected IMetaStoreClient newClient() {
try {
try {
- return CLIENT_CTOR.newInstance(hiveConf);
+ return CLIENT_CTOR.invoke(hiveConf, true);
Review comment:
it's not about retry, but to configure `allowEmbedded` for the
`HiveMetaStoreClient` initialized internally in the `RetryingMetaStoreClient`:
https://github.com/apache/hive/blob/9f03e3c416834b18faf7a85338b130ed0742275f/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java#L165-L167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
