szehon-ho commented on a change in pull request #3099:
URL: https://github.com/apache/iceberg/pull/3099#discussion_r715796926
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -47,10 +49,15 @@ public HiveClientPool(int poolSize, Configuration conf) {
}
@Override
- protected HiveMetaStoreClient newClient() {
+ protected boolean shouldRetry() {
+ return false; // Already use RetryingMetaStoreClient
+ }
+
+ @Override
+ protected IMetaStoreClient newClient() {
try {
try {
- return CLIENT_CTOR.newInstance(hiveConf);
+ return CLIENT_CTOR.invoke(hiveConf, true);
Review comment:
Yes, thanks @jackye1995 for the pointer. From quick glance, seems a
flag just intended to determine whether to throw an exception if
"hive.metastore.uris" is not set, so not terribly useful to document, unless
you feel otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
