nastra commented on pull request #3353: URL: https://github.com/apache/iceberg/pull/3353#issuecomment-951990039
@rdblue suggested that we try and extract the version info from existing tags. I did some experimenting with the existing and other gradle git plugins. Most plugins were not exactly doing what we need or didn't really have a good way of being configured or were quite old and not maintained anymore, so I ended up using the existing git plugin that we already have (`com.palantir.git-version`). It supports searching for tag prefixes via `gitVersion(prefix: 'apache-iceberg-')` but that requires that our tags are annotated slightly different as the `prefix` must match a regex of the form `[/@]?([A-Za-z]+[/@-])+`, thus I adjusted the part where we annotate the tags from `Apache Iceberg x.y.z` to `apache-iceberg-x.y.z`. Also `gitVersion(prefix: 'apache-iceberg-')` just spits out a plain string and doesn't give any flexibility of extracing the MAJOR.MINOR.PATCH parts, thus I had to do some regex matching to extract what we need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
