rdblue commented on a change in pull request #3353:
URL: https://github.com/apache/iceberg/pull/3353#discussion_r736708122
##########
File path: dev/source-release.sh
##########
@@ -88,7 +88,7 @@ git add $projectdir/version.txt
git commit -m "Add version.txt for release $version" $projectdir/version.txt
set_version_hash=`git rev-list HEAD 2> /dev/null | head -n 1 `
-git tag -am "Apache Iceberg $version" $tagrc $set_version_hash
+git tag -a "$tag" -m "Apache Iceberg $version" $tagrc $set_version_hash
Review comment:
The tag name is already present later in the command, `$tagrc`. And the
git docs don't say that `-a` takes any arguments. When I run a test of this, it
fails with `fatal: too many params`, so I don't think that this actually works
because it is adding a tag name multiple times.
It looks like you're trying to work around one of two things:
1. The tag isn't on the master branch, it is on the commit that adds
`verison.txt` that is never in master
2. The tag name includes the `-rcX` suffix
I think it is more likely that you're working around the first because we
add a new tag without the `-rcX` suffix when the release is final. You can see
an example here:
https://github.com/apache/iceberg/releases/tag/apache-iceberg-0.12.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
