nastra commented on a change in pull request #3353:
URL: https://github.com/apache/iceberg/pull/3353#discussion_r736730806
##########
File path: dev/source-release.sh
##########
@@ -88,7 +88,7 @@ git add $projectdir/version.txt
git commit -m "Add version.txt for release $version" $projectdir/version.txt
set_version_hash=`git rev-list HEAD 2> /dev/null | head -n 1 `
-git tag -am "Apache Iceberg $version" $tagrc $set_version_hash
+git tag -a "$tag" -m "Apache Iceberg $version" $tagrc $set_version_hash
Review comment:
you're right, I don't know why I ended up assuming that the tagging
annotation part was wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
