kbendick commented on a change in pull request #3509:
URL: https://github.com/apache/iceberg/pull/3509#discussion_r745899082
##########
File path: .github/workflows/java-ci.yml
##########
@@ -28,12 +28,6 @@ on:
- '.github/workflows/cancel-duplicate-workflow-runs.yml'
- '.gitignore'
- 'dev/**'
- - 'mr/**'
- - 'hive3/**'
- - 'hive3-orc-bundle/**'
- - 'hive-runtime/**'
- - 'spark/**'
- - 'flink/**'
Review comment:
So this _will_ solve your problem, but it might also lead to running
`java-ci` a lot more than is necessary, as it does more than just checkstyle.
Am I correct in thinking that we're just trying to ensure checkstyle runs
over changed files? Is there a way we can avoid running the additional 6-11
minute action that makes up all of `java-ci` for all of these paths if we only
need a subset of it?
Or maybe we can run checkstyle in its own workflow to avoid having to run it
in every single workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
