kbendick commented on pull request #3509: URL: https://github.com/apache/iceberg/pull/3509#issuecomment-964830155
> Oh, I see. The correct way to enable checkstyle check for flink modules is removing the ignored flink paths in java-ci.yaml, instead of enabling all the engines checkstyle check by removing the `-Pquick=true`. I think it would be better to keep the ignors as are, but remote `-Pquick=true` instead. That way we keep the tests shorter by only running them for the change set they belong too (as well as more parallel). I am also working on a PR to make them all exit early if one fails (like before when they were one file). Running all of them if it's possile to avoid it uses up limited capacity for GH Actions (the whole Apache organization shares one set of runners which is pretty limited in size relatively speaking). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
