openinx commented on a change in pull request #3509:
URL: https://github.com/apache/iceberg/pull/3509#discussion_r746288463
##########
File path: .github/workflows/java-ci.yml
##########
@@ -28,12 +28,6 @@ on:
- '.github/workflows/cancel-duplicate-workflow-runs.yml'
- '.gitignore'
- 'dev/**'
- - 'mr/**'
- - 'hive3/**'
- - 'hive3-orc-bundle/**'
- - 'hive-runtime/**'
- - 'spark/**'
- - 'flink/**'
Review comment:
In my view, the overall checkstyle check is necessary. I think the
problem is: removing all those ignored engine paths will trigger the extra
`iceberg-core` unit tests check. Because if any engine related changes happen ,
it will always run the iceberg-core unit tests (even we don't ) I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
