rdblue commented on a change in pull request #3509:
URL: https://github.com/apache/iceberg/pull/3509#discussion_r748910150



##########
File path: .github/workflows/java-ci.yml
##########
@@ -28,12 +28,6 @@ on:
     - '.github/workflows/cancel-duplicate-workflow-runs.yml'
     - '.gitignore'
     - 'dev/**'
-    - 'mr/**'
-    - 'hive3/**'
-    - 'hive3-orc-bundle/**'
-    - 'hive-runtime/**'
-    - 'spark/**'
-    - 'flink/**'

Review comment:
       I agree with @openinx. This common rule is the one that should be 
running the checks. This is to avoid making all of the CI builds more expensive 
because checkstyle and errorprone take a long time to run.
   
   One thing that we still need to do after this is enable all Flink, Spark, 
and Hive versions in the job config, not just the default ones.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to