rdblue commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r751722240
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java
##########
@@ -66,6 +67,12 @@ private void verifyInputAndOutputFiles(Set<DataFile>
dataFilesToDelete, Set<Dele
}
}
+ @Override
+ public RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile>
filesToAdd, long sequenceNumber) {
Review comment:
Slightly unrelated concern: should we be using `Set` here? It seems
needlessly restrictive. Plus, `DataFile` is an interface, so you could easily
pass files that don't implement equals/hashSet and are always considered
unique. Just one thing that's always made me wonder about this API.
Not a blocker for this PR though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
