rdblue commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r750504430
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -297,7 +299,14 @@ protected void validateAddedDataFiles(TableMetadata base,
Long startingSnapshotI
*/
protected void validateNoNewDeletesForDataFiles(TableMetadata base, Long
startingSnapshotId,
Iterable<DataFile>
dataFiles) {
- validateNoNewDeletesForDataFiles(base, startingSnapshotId, null,
dataFiles, true);
+ validateNoNewDeletesForDataFiles(base, startingSnapshotId, null,
dataFiles, true,
+ sequenceNumberForNewDataFiles != null);
+ }
+
+ protected void validateNoNewDeletesForDataFiles(TableMetadata base, Long
startingSnapshotId,
Review comment:
Could you copy the javadoc for the previous version? I think it's
helpful to have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
