rdblue commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r750507550
##########
File path: api/src/main/java/org/apache/iceberg/RewriteFiles.java
##########
@@ -73,4 +73,13 @@ RewriteFiles rewriteFiles(Set<DataFile> dataFilesToReplace,
Set<DeleteFile> dele
* @return this for method chaining
*/
RewriteFiles validateFromSnapshot(long snapshotId);
+
+ /**
+ * Use the specified sequence number for the new manifest of the data files
added in this update,
+ * instead of inheriting the sequence number of the snapshot that will be
created.
+ *
+ * @param sequenceNumber a sequence number
+ * @return this for method chaining
+ */
+ RewriteFiles overrideSequenceNumberForNewDataFiles(long sequenceNumber);
Review comment:
This looks like a fairly clean way to configure everything now that I'm
looking at context. Up to you whether to use `rewriteFiles` to pass it or a new
method, but I think we should come up with a shorter name if we go with the new
method approach. What about `dataFileSequenceNumber`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
