jackye1995 commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r751668358
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
##########
@@ -77,6 +77,17 @@
*/
String TARGET_FILE_SIZE_BYTES = "target-file-size-bytes";
+ /**
+ * If the compaction should use the sequence number of the snapshot at
compaction start time for new data files,
+ * instead of using the sequence number of the newly produced snapshot.
+ * <p>
+ * This avoids commit conflicts with updates that add newer equality deletes
at a higher sequence number.
+ * <p>
+ * Defaults to true.
+ */
+ String USE_STARTING_SEQUENCE_NUMBER = "use-starting-sequence-number";
+ boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true;
Review comment:
Yeah I was thinking about that right now. Technically I think it has no
harm for v1 tables, because the sequence number is always 0, and it is not read
or written anywhere. Let me add a unit test for v1. Do you see any place this
might affect v1 table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
