rdblue commented on a change in pull request #4016:
URL: https://github.com/apache/iceberg/pull/4016#discussion_r800232359
##########
File path: python/src/iceberg/types.py
##########
@@ -93,21 +128,37 @@ def precision(self) -> int:
def scale(self) -> int:
return self._scale
- def __eq__(self, other):
- if type(self) is type(other):
- return self.precision == other.precision and self.scale ==
other.scale
- return False
+class NestedField(IcebergType):
+ """equivalent of `NestedField` type from Java implementation"""
Review comment:
Doc strings should use normal sentence case, so this should start with a
capital letter.
Also, I don't think that we want to refer to the Java implementation. This
represents a field of a struct, a map key, a map value, or a list element. This
is where field IDs, names, docs, and nullability are tracked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
