rdblue commented on a change in pull request #4016:
URL: https://github.com/apache/iceberg/pull/4016#discussion_r800233479
##########
File path: python/tests/test_types.py
##########
@@ -101,9 +101,7 @@ def test_struct_type():
assert len(type_var.fields) == 3
assert str(type_var) == str(eval(repr(type_var)))
assert type_var == eval(repr(type_var))
- assert type_var != StructType(
- [NestedField(True, 1, "optional_field", IntegerType())]
- )
+ assert type_var != StructType([NestedField(True, 1, "optional_field",
IntegerType())])
Review comment:
Can you add tests for `is_primitive`? I don't think those would be
passing because many of the types aren't inheriting from `PrimitiveType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
