rdblue commented on a change in pull request #4016:
URL: https://github.com/apache/iceberg/pull/4016#discussion_r800232677
##########
File path: python/src/iceberg/types.py
##########
@@ -93,21 +128,37 @@ def precision(self) -> int:
def scale(self) -> int:
return self._scale
- def __eq__(self, other):
- if type(self) is type(other):
- return self.precision == other.precision and self.scale ==
other.scale
- return False
+class NestedField(IcebergType):
+ """equivalent of `NestedField` type from Java implementation"""
+
+ _instances: Dict[Tuple[bool, int, str, IcebergType, Optional[str]],
"NestedField"] = {}
+
+ def __new__(
+ cls,
+ is_optional: bool,
+ field_id: int,
+ name: str,
+ field_type: IcebergType,
+ doc: Optional[str] = None,
+ ):
+ key = is_optional, field_id, name, field_type, doc
+ cls._instances[key] = cls._instances.get(key) or object.__new__(cls)
Review comment:
Need to pass arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
