rdblue commented on a change in pull request #4016:
URL: https://github.com/apache/iceberg/pull/4016#discussion_r800233373
##########
File path: python/src/iceberg/types.py
##########
@@ -305,10 +364,10 @@ class DoubleType(Type, Singleton):
"""
def __init__(self):
- super().__init__("double", "DoubleType()", is_primitive=True)
+ super().__init__("double", "DoubleType()")
-class DateType(Type, Singleton):
+class DateType(IcebergType, Singleton):
Review comment:
These all need to be `PrimitiveType` to make the `is_primitive` check
work, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
