CircArgs commented on a change in pull request #4016:
URL: https://github.com/apache/iceberg/pull/4016#discussion_r800839125
##########
File path: python/src/iceberg/types.py
##########
@@ -305,10 +364,10 @@ class DoubleType(Type, Singleton):
"""
def __init__(self):
- super().__init__("double", "DoubleType()", is_primitive=True)
+ super().__init__("double", "DoubleType()")
-class DateType(Type, Singleton):
+class DateType(IcebergType, Singleton):
Review comment:
Yeah I messed it up when mergins in Jun's
##########
File path: python/src/iceberg/types.py
##########
@@ -305,10 +364,10 @@ class DoubleType(Type, Singleton):
"""
def __init__(self):
- super().__init__("double", "DoubleType()", is_primitive=True)
+ super().__init__("double", "DoubleType()")
-class DateType(Type, Singleton):
+class DateType(IcebergType, Singleton):
Review comment:
Yeah I messed it up when mergin in Jun's
##########
File path: python/src/iceberg/types.py
##########
@@ -305,10 +364,10 @@ class DoubleType(Type, Singleton):
"""
def __init__(self):
- super().__init__("double", "DoubleType()", is_primitive=True)
+ super().__init__("double", "DoubleType()")
-class DateType(Type, Singleton):
+class DateType(IcebergType, Singleton):
Review comment:
Yeah I messed it up when merging in Jun's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
