kbendick commented on a change in pull request #4050: URL: https://github.com/apache/iceberg/pull/4050#discussion_r801965294
########## File path: api/src/main/java/org/apache/iceberg/io/FileIOMetrics.java ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.io; + +import java.io.Serializable; +import java.util.Map; + +/** + * Optional interface for FileIO implementations to report metrics related + * to read/write operations. + */ +public interface FileIOMetrics extends Serializable { + String READ_BYTES = "read.bytes"; Review comment: I'd definitely encourage you to take a look at the Flink metric implementation. It worked well for me to be able to use their metrics, plus my own metrics via the Prometheus metrics library, and merge them together. And it provides shims to various metric formats and is used for the same purpose (hadoop fs metrics): https://github.com/apache/flink/tree/master/flink-metrics But I still agree that the simplest approach should be chosen initially to get the metrics working for S3FileIO. It wouldn't be hard to adapt them later and it's a highly requested feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
