danielcweeks commented on a change in pull request #4050:
URL: https://github.com/apache/iceberg/pull/4050#discussion_r802151968
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java
##########
@@ -81,6 +89,8 @@ public int read() throws IOException {
pos += 1;
next += 1;
+ readBytes.increment(1L);
Review comment:
Yeah, this method shouldn't really be called at all (if you go back to
the original implementation we were considering not even including it). This
is more for completeness of the InputStream api as opposed to trying to be
performant.
tl;dr don't use this method :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
