dungdm93 commented on a change in pull request #4132:
URL: https://github.com/apache/iceberg/pull/4132#discussion_r808913155
##########
File path: api/src/main/java/org/apache/iceberg/PartitionKey.java
##########
@@ -98,11 +98,12 @@ public String toPath() {
* @param row a StructLike row
*/
@SuppressWarnings("unchecked")
- public void partition(StructLike row) {
+ public PartitionKey partition(StructLike row) {
Review comment:
This is just sidecar change, I made it to align with other `StructLike`
wrapper, `StructProjection.wrap`, `IndexedStructLike.wrap`,
`InternalRowWrapper.wrap`,... to name a few.
@openinx Could you tell me why this can make an api compatibility issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
