jackye1995 commented on pull request #4175: URL: https://github.com/apache/iceberg/pull/4175#issuecomment-1047224924
Thanks for the fix, to provide more context to other people who are interested, when 2 AWS clients inherit the same HTTP client, AWS will choose to not close the HTTP client to be safe. However, this means users will never have the ability to close the underlying HTTP client in this case, because the client is private. This fix allows users to at least be able to control the lifecycle of the HTTP client and have the option to close the HTTP client as a part of the AWS client if necessary. However, @arminnajafi one of the experiment we did was that the if the HTTP client is passed in in this way of `someAwsClient.builder().httpClient(...)`, it's still treated as external and not closed. Can you see if there is another way to make sure the AWS client and the underlying HTTP client can be closed at the same time when `someAwsClient.close()` is called? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
