jackye1995 commented on a change in pull request #4175:
URL: https://github.com/apache/iceberg/pull/4175#discussion_r812524869
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/TestAssumeRoleAwsClientFactory.java
##########
@@ -58,7 +60,7 @@ public void before() {
roleName = UUID.randomUUID().toString();
iam = IamClient.builder()
.region(Region.AWS_GLOBAL)
- .httpClient(UrlConnectionHttpClient.create())
+ .httpClientBuilder(HTTP_CLIENT_BUILDER_DEFAULT)
Review comment:
Based on your link:
> When there is no desire to share HTTP clients across multiple service
clients, the client builder is the preferred way to customize the HTTP client
as it benefits from service-specific default configuration.
So we should initialize a new HTTP client for every client, they should not
share the HTTP client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
