arminnajafi commented on pull request #4175: URL: https://github.com/apache/iceberg/pull/4175#issuecomment-1048395946
@jackye1995 Thanks a lot Jack for the review and insights. PR is updated to: 1. Use `.httpClientBuilder()` instead of `.httpClient()` which is intended for our purpose: https://github.com/aws/aws-sdk-java-v2/blob/master/core/sdk-core/src/main/java/software/amazon/awssdk/core/client/builder/SdkSyncClientBuilder.java#L32-L56 2. Use `ApacheHttpClient` instead of `UrlConnectionHttpClient` since according to some recent internal experiments we found that ApacheHttpClient is more reliable, especially for Enterprise users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
