jackye1995 commented on a change in pull request #4175:
URL: https://github.com/apache/iceberg/pull/4175#discussion_r812525563
##########
File path: build.gradle
##########
@@ -312,6 +312,7 @@ project(':iceberg-aws') {
implementation project(':iceberg-core')
compileOnly 'software.amazon.awssdk:url-connection-client'
+ compileOnly 'software.amazon.awssdk:apache-client'
Review comment:
let's focus this PR around using URL connection client correctly.
After this one we can introduce the use of Apache client. The reason is that
we should keep the current behavior since users bring a `url-connection-client`
in their environment will see ClassNotFoundError if we directly switch to
`apache-client`. I think we should offer a catalog config in `AwsProperties`,
something like `client.http.type`, where it could be `url` or `apache`. Does
that work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
