kainoa21 commented on a change in pull request #4183:
URL: https://github.com/apache/iceberg/pull/4183#discussion_r811501438
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -21,10 +21,12 @@
import java.io.Serializable;
import java.util.Map;
+import org.apache.flink.table.factories.CatalogFactory;
import org.apache.hadoop.conf.Configuration;
Review comment:
We can eventually if we want to strip out references from the existing
Hadoop and Hive catalog implementations. As it stands, the `Configuration`
class is only loaded if a catalog ends up calling
`HadoopUtils.getHadoopConfiguration(GlobalConfiguration.loadConfiguration())`
which is avoided for catalogs which are loaded by passing `catalog-impl` AND
when `org.apache.hadoop.conf.Configuration` isn't available to Flink's
application level class loader (even if it is available to the user lib
classloader).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
