kbendick commented on a change in pull request #4183:
URL: https://github.com/apache/iceberg/pull/4183#discussion_r811526006



##########
File path: 
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -44,17 +46,27 @@
    *
    * @return a newly created {@link Catalog}
    */
-  Catalog loadCatalog();
+  String getName();
+  Map<String, String> getOptions();
+  Object getConf();

Review comment:
       The interface for `setConf` that avoids needing hadoop is found here: 
https://github.com/apache/iceberg/blob/da84a9c0740c9909889780b4350e113cfd35a4ae/core/src/main/java/org/apache/iceberg/hadoop/Configurable.java#L22-L27
   
   We might just want to add `getConf` to that as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to