kainoa21 commented on a change in pull request #4183:
URL: https://github.com/apache/iceberg/pull/4183#discussion_r811502076
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -126,8 +129,43 @@ public Catalog createCatalog(String name, Map<String,
String> properties) {
return createCatalog(name, properties, clusterHadoopConf());
}
- protected Catalog createCatalog(String name, Map<String, String> properties,
Configuration hadoopConf) {
- CatalogLoader catalogLoader = createCatalogLoader(name, properties,
hadoopConf);
+ @Override
+ public String factoryIdentifier() {
+ return FACTORY_IDENTIFIER;
+ }
+
+ @Override
+ public Set<ConfigOption<?>> requiredOptions() {
Review comment:
Not sure what we would want to return for required or optional options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
