kainoa21 commented on a change in pull request #4183:
URL: https://github.com/apache/iceberg/pull/4183#discussion_r812071336
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -44,17 +46,27 @@
*
* @return a newly created {@link Catalog}
*/
- Catalog loadCatalog();
+ String getName();
+ Map<String, String> getOptions();
+ Object getConf();
Review comment:
IMO there are two independent questions we want to answer at runtime.
1) Can the runtime environment provide Hadoop configuration?
2) Does the catalog accept Hadoop configuration?
The existing Configurable interface addresses the second question. But we
still need Flink to answer the first one. In an ideal case, Flink would
directly provide an answer via the Context param somehow.
I also don't think adding getConf to the Iceberg Configurable interface
really gets us anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
